version-checker icon indicating copy to clipboard operation
version-checker copied to clipboard

Replaced `docker` with `image`

Open ChaosInTheCRD opened this issue 4 years ago • 5 comments

the command on the makefile seems to have moved from docker to image, this cleans that up.

ChaosInTheCRD avatar Jan 13 '21 17:01 ChaosInTheCRD

@ChaosInTheCRD: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 13 '21 17:01 jetstack-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ChaosInTheCRD To complete the pull request process, please assign joshvanl You can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Jan 13 '21 17:01 jetstack-bot

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • acf60d0 Replaced 'docker' with 'image'
  • 6e03b36 Merge remote-tracking branch 'origin/fix-makefile' into fix-makefile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Jan 14 '21 10:01 jetstack-bot

/lgtm

JoshVanL avatar Feb 15 '21 17:02 JoshVanL

@ChaosInTheCRD Can you sign off your commits please.

davidcollom avatar Aug 22 '22 18:08 davidcollom