version-checker icon indicating copy to clipboard operation
version-checker copied to clipboard

Resolve SHA256 to tags automatically if the images specified in the k8s manifests doesn't contain tag.

Open jahantech opened this issue 4 years ago • 5 comments

We currently have a case where the images are resolved to sha256 digest before being added to the manifest. Which means it becomes impossible for us to resolve them back to tags with the current functionality of the version checker. These changes allow the resolution of tags from sha256 in the image field.

jahantech avatar Jan 04 '21 15:01 jahantech

@jahantech: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 04 '21 15:01 jetstack-bot

Hi @jahantech. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 04 '21 15:01 jetstack-bot

Any update on this please if this feature is acceptable? thank you

jahantech avatar Feb 10 '21 16:02 jahantech

Hmm, the problem with this is that multiple tags can be assigned to the same sha. In this current implementation we are just taking the first we come across. This can be wrong most of the time.

JoshVanL avatar Feb 15 '21 17:02 JoshVanL

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jahantech To complete the pull request process, please assign joshvanl after the PR has been reviewed. You can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Aug 22 '22 17:08 jetstack-bot