version-checker icon indicating copy to clipboard operation
version-checker copied to clipboard

Published 20 hours ago • verified publisher icon jetstack

WIP:Add architecture and os checks when fetching tags

Open tfadeyi opened this issue 3 years ago • 4 comments

This updates the controller to check the architecture of the cluster nodes and select only tags for the current architecture.

Going to handle the composite hashes in a following PR.

needs: #61

Signed-off-by: oluwole.fadeyi [email protected]

tfadeyi avatar Nov 16 '20 09:11 tfadeyi

@tfadeyi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Nov 16 '20 09:11 jetstack-bot

/hold /approve /lgtm

JoshVanL avatar Nov 19 '20 12:11 JoshVanL

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, tfadeyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Nov 19 '20 12:11 jetstack-bot

@tfadeyi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 03 '23 23:01 jetstack-bot

Hey @tfadeyi, this has been open a while and needs a rebase at least.

Are you interested in updating this branch and getting this feature into version-checker? If not I can try to see if someone else can take over here.

hawksight avatar Apr 11 '24 07:04 hawksight

Hey @tfadeyi, this has been open a while and needs a rebase at least.

Are you interested in updating this branch and getting this feature into version-checker? If not I can try to see if someone else can take over here.

Hey @hawksight I think we could have someone take over, or close this PR. I don't fully remember but there were some edge cases with multi-arch images that this PR won't cover

tfadeyi avatar Apr 11 '24 09:04 tfadeyi

@tfadeyi - thanks for feedback.

We will close this as it's quite old but use it as a good reference point for a new implementation from a fresh branch.

Created #181 to track discussion / progress on the topic.

hawksight avatar Apr 25 '24 08:04 hawksight