jetstack
Issue 66 - AWS ECR Credentials
This PR fix issue: https://github.com/jetstack/version-checker/issues/66
The AWS sdk has by default many ways to configure the credentials, through environment variables, using kubernetes IRSA... I think the best option is to use the default credential provider chain so the final user can choose how to configure credentials. This solution also has the same option as before configuring AWS environment variables. Specifying Credentials: https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html
Environment variables VERSION_CHECKER_ECR_ACCESS_KEY_ID, VERSION_CHECKER_ECR_SECRET_ACCESS_KEY and VERSION_CHECKER_ECR_SESSION_TOKEN are no longer used. Now uses the AWS sdk default credential provider chain. More info: [https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html](https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html) [Specifying Credentials] section
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chelomontilla
To complete the pull request process, please assign joshvanl after the PR has been reviewed.
You can assign the PR to them by writing /assign @joshvanl in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @chelomontilla. Thanks for your PR.
I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi, this is taking too long to merge. Is there something I can do on my side to help? Thanks.
Thanks @chelomontilla , apologies for the delay on this.
/lgtm /hold Let’s merge when we are ready to release v0.3.0
@chelomontilla: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
