Jelle Zijlstra

Results 643 comments of Jelle Zijlstra

You need to add `-e suggested_parameter_type` and/or `-e suggested_return_type` I believe so that it emits the right diagnostics in the report.

I think `.attrs` is wrong instead; attrs can in fact be lists. Example: ``` In [9]: html = 'x' In [11]: from bs4 import BeautifulSoup ...: soup = BeautifulSoup(html, 'html.parser')...

I originally typed `attrs` as `Mapping[str, Any]` but #5907 changed it to `Mapping[str, str]`, and later #7253 changed it to a dict instead of a Mapping.

No, because TypeVarTuple can't be used to type a heterogeneous list.

Note that the master branch of urllib3 is *not* what it is currently releasing; the current release doesn't have the types yet. This confused us for a while in #6892.

Thanks @hauntsaninja, I missed that method. We can't make Task covariant either, because `Task.set_result` would still be unsafe.

I'm still hesitant about having a covariant subclass of an invariant base class. Given `B

Could you address @Akuli's feedback?

Perhaps we could run OS-specific stubtest only for specific packages where we know there are differences.

@atagar https://docs.python.org/3/library/typing.html#typing.overload