Jelle Zijlstra

Results 643 comments of Jelle Zijlstra

Thanks so much for working on this @msullivan. I say we should blacken blib2to3 too if we are going to add annotations to it anyway. @zsol @ambv do you agree?

Yes, we run it twice in normal mode to deal with some other intractable stability issues. I guess we could also rely on the double run for this PR, but...

hm this seems wrong in @ichard26's report (in django somewhere): ``` for sql in ( - 'OFFSET %d ROWS' % offset if offset else None, - 'FETCH FIRST %d ROWS...

This one is also odd: ``` clone._iterable_class = ( NamedValuesListIterable if named - else FlatValuesListIterable - if flat - else ValuesListIterable + else FlatValuesListIterable if flat else ValuesListIterable ) ```

I still like most of what this change does, but there are a few weird cases (noted in my comment above). Also, we'll now have to make this go into...

We added the spacing on purpose to make the code clearer. Could docformatter change instead?

Thanks for reporting this! I don't have time to investigate in detail right now, but here's a few things that anyone reading this could do to help: - The crash...

Looking at the results of this change, I'm not sure it's really worth it. The diff shows that this is a pretty common pattern, so this would be a relatively...

To be clear my current preference is just to never add these parentheses, it's just that the parens are more jarring in cases where the LHS of the == is...

This will now need to go in the preview style only. (And my personal preference is still to just not change anything here, but the preview style does allow us...