Jelle Zijlstra

Results 643 comments of Jelle Zijlstra

I feel like it's better to err on the side of listing more codes in our docs, just in case people explicitly turn on the code or flake8 changes its...

> ok, can you help me understand why we parse `python 3.0`, when a user asks to parse `py36`? We don't have separate grammars for every version. For py36 we...

It's the target version, which gets passed as a command-line parameter and thence as an argument to `main()`.

I'm still not enthusiastic about this: - Hardcoding the list of versions is a little hacky and hard to maintain - I'm afraid the error message may still be confusing...

I just updated the stable branch. I thought that was supposed to be automated, so leaving this open to figure out why the automation isn't working.

I suppose this is Black strongly dislikes backslashes. I'm not sure there's really a great formatting Black can pick here.

Also, with the new stability policy, this change would need to go only into the `--preview` style.

Looks like it's part of the stable ABI, so for the moment we can't get rid of it. It was used in 2.7: https://github.com/python/cpython/blob/8d21aa21f2cbc6d50aab3f420bb23be1d081dac4/Python/ceval.c#L4499

Probably, I'll take another look tonight and merge if I'm happy.

I'm not overly familiar with memory management around the shutdown sequence, but shouldn't these caches get collected automatically when the module object is deallocated and its dict is cleared? Or...