Jelle Zijlstra

Results 643 comments of Jelle Zijlstra

I think I'd prefer to implement Rebecca's second suggestion. This would not require a new special file format, and it would generalize to third-party packages more easily. Suggested specification: The...

Unfortunately this has severe merge conflicts now. If you fix them, I will review the PR.

I feel like a more principled solution might be to include the data from the METADATA.toml in the dist-info directory somehow, instead of in the stubs directory. After all, the...

Apparently 66.1 only has Windows wheels: https://pypi.org/project/cefpython3/#files. Maybe we should provide stubs for 66.0 for now.

Could you skip the stubs in stubtest for now as @AlexWaygood suggested?

Thanks for contributing! I'm closing this PR for now, because it still fails some tests and has unresolved review feedback after three months of inactivity. If you are still interested,...

Thanks for contributing! I'm closing this PR for now, because it still fails some tests after three months of inactivity. If you are still interested, please feel free to open...

Since `--enable-incomplete-feature` is meant for experimental features that may not work properly yet, I think we shouldn't write typeshed stubs that rely on it. But on the mypy side, maybe...

I agree this looks a bit excessive. Maybe we can use `type=` (https://docs.python.org/3.10/library/argparse.html#type) instead of `choices` to validate the arguments, and add to the help text something pointing to docs...

Thanks for offering to work on this! I think it can be implemented basically by having the current code that checks for `# static analysis: ignore` also check for `#...