Jake Wharton

Results 1650 comments of Jake Wharton

Doesn't the platform `SearchView` also have this behavior?

When was this implemented for Android? I think it's 4.1 or later which means ABS doesn't support it because it attempts to match the behavior of 4.0.

I would love a small demo app or if you could condense it into a single class and paste it somewhere.

That commit was introduced to workaround a complication in the support library where it always returns true for menu creation which was leading to problems with invalidation. The new behavior...

Can you detail more about why this is needed? I don't remember having ever seen an issue around this.

Just a heads up. I'm not even going to look at this until r11 or newer is in Maven central.

What version of ABS? I think this was already fixed.

If you look closely I don't think the close button animates on subsequent launches of the action mode either

I think this specific bug is fixed. Subsequent action mode close buttons are clickable on all supported platforms. The problem still exists where it doesn't animate on every instance after...