Jake Wharton

Results 1650 comments of Jake Wharton

Yeah. And that's unfortunate. We should do non-relative too. PRs welcome. On Mon, Feb 5, 2018 at 5:34 PM Tomasz Rykała wrote: > True, thanks. So replace set with update,...

Please retain an overload with the old signature and a deprecated annotation with a visibility of hidden to maintain binary compatibility as well.

Sure! On Tue, Feb 6, 2018 at 11:48 AM Dave Thomas wrote: > Does it make sense to upgrade signature for doOnLayout and doOnNextLayout > to use generics as well?...

This seems like a feature that should wait for inline classes in Kotlin 1.3 such that we can make the types of these properties zero-overhead wrappers around `Resources` such that...

That assumes people will use it in that manner. And in the case where they only want a single resource the allocations have jumped to 2 and the calling semantics...

This might be a dokka bug.

This seems too hyper-specific for my taste because it means adding one function for every system UI flag. Exposing an easier way to enable or disable a system UI flag,...

Does this really add much value? It causes allocation of varags and pairs for something that isn't much less verbose than the existing `edit`-with-lambda approach. I'd rather figure out how...

We'd do overloads. No need to switch. On Mon, Feb 5, 2018, 6:56 PM Prateek Srivastava wrote: > Instead you could have something an extension function on > SharedPreferences.Editor —put(key:...

And delete is already `remove("key")` which is hard to improve upon.