JakeQZ

Results 217 comments of JakeQZ

From experience, if a `rebase` is required, the procedure can go awry if not performed carefully. The following is a tried-and-tested procedure to rebase a ‘feature’ branch to the latest...

x-ref: https://github.com/MyIntervals/emogrifier/pull/804#discussion_r332281248

Some notes about potential pitfalls, mostly for classification/recollection at this stage as we indulge in Psalm - off the top of my head: - splitting PRs into manageable chunks -...

Another one: - Side chat - If there's something to discuss that doesn't relate to the issue in hand, let's create a new 'issue' for it where we can discuss...

> * issues with GitHub UX (TBD) I've put in a feature request or two - see https://github.com/dear-github/dear-github/issues/362

> * Side chat On the other side of the coin, I think friendly comments like "nice catch" or "good job" should be welcomed. Trying to strike a balance here...

Ths instructions for installing the development dependencies need to be updated to include installing tools with PHIVE, and with which tools are now used. Also, IIRC, we no longer need...

Is it any or much better than [PHP-CSS-Parser](https://github.com/sabberworm/PHP-CSS-Parser), and is it worth the effort making switching possible? I suppose in some ways checking it out could help us streamline our...

> * There is a php 5.6 and up version at https://github.com/tbela99/css/tree/php56-backport . It is on par with the php 8 branch. Not sure how that would or could work...

We would also (somehow) need to make sure they don't sit around hogging memory once `CssInliner` has been used.