JakeQZ

Results 217 comments of JakeQZ

Doesn't #544 already cover this (apart from the issues I mentioned in my previous comment here)?

But isn't this issue, #734, a duplicate of #544?

I've added #738 and #739 for the side issues I mentioned.

I've looked at a few PHP CSS minification tools (one of which I use), and they've all used their own regex parsing. I'm not familiar with either of the above.

I've read the readmes of the two suggested possibilities, but have not looked in any detail... > * https://packagist.org/packages/sabberworm/php-css-parser Looks like it would parse the CSS and organize into an...

> > ``` > > * https://packagist.org/packages/sabberworm/php-css-parser > > ``` > > Looks like it would parse the CSS and organize into an OO data structure along the lines of...

Having subconsciously thought about https://github.com/MyIntervals/emogrifier/pull/912#issuecomment-653879492 > move the CSS parsing either to a separate class or use an existing package for a while, I think we should probably do both:...

If using an IDE, or indeed any editor supporting multiple file types, wouldn't it make sense for the line length limit to be the same across all file types for...

Continuing the discussion from #826... > (An interface would help if there were multiple packages with different APIs that provide the same functionality as this repo does.) Or if one...

> * protected methods marked `@internal` = no promise That's my point - there is no promise - use at your own risk. Though I can see a potential for...