JakeQZ

Results 217 comments of JakeQZ

I'm just thinking of the general case. #668 was just an example. I don't think any methods should be made part of the API without a valid reason. Though I...

Not a bad idea. I'd be willing to bet that there aren't any, but wouldn't offer better than even money, as it's quite possible we may have missed something. I'm...

On the OP, I think we are unlikely to reach consensus between the two of us, and on that basis we should do nothing. But before closing this, I'd like...

> I would leave things as is, unless there are known use cases or there have been requests to change these methods to protected. #103 is the only other that...

Somewhat alluded to in the above links is the idea of wrapping prose after every sentence, as this allows for cleaner commits when making minor alterations to it. This could...

There is also an 80 character line length argument for [readability of prose in general](https://duckduckgo.com/?q=ideal+line+length+for+readability) (or perhaps about 66 characters). When editing, we still need to be able to read...

Once the `Emogrifier` class is removed, we can do this, as we require installation with Composer and an autoloader (or something to that effect) to use the new classes and...

Hi @kaaaaaaaaaaai, Good question. (I was just looking at this recently and wondering if it would be preferable to SASS, etc.) Emogrifier currently has no special processing of custom properties....

> I'm trying to read the code, but I can't think of any way to respond. Yeah, I can appreciate not being familiar with the code and/or how Emogrifier works,...

The version we have matches the one at https://github.com/vimeo/psalm/releases/download/4.7.0/psalm.phar and I also find the same issue with 4.6.4.