JakeQZ

I confirmed these result from using CSS Parser 8.4 and pass with 8.3.1. The second is because the invalid rule is now stripped out by CSS Parser so it never...

The other looks very closely related but is a bug introduced into CSS Parser. With the new version, the valid CSS rule `[href=https://example.org]{ color: green; }` is now being discarded....

> is a bug ...unless I'm mistaken and `[href=https://example.org]` is actually an invalid selector, but AFAIK there is no requirement to quote the value in this case.

There's a 'lenient parsing' option but that is `true` by default and hasn't changed between 8.3.1 and 8.4. I also can't see anything obvious in the changelog suggesting the change...

https://github.com/sabberworm/PHP-CSS-Parser/pull/162 appears to be the culprit, the commit https://github.com/sabberworm/PHP-CSS-Parser/commit/2c5cd6ffac1c4282ceb22f2da67dbba3c6640f00

I think how to address the bug in the CSS Parser perhaps needs some discussion with a focus on longer term. Maybe it is possible to fix the regex here,...

> The second is because the invalid rule is now stripped out by CSS Parser so it never reaches Symfony for it to throw an exception. Will need to look...

> Our test is wrong, and we should remove it altogether Actually we should change the tests to use quoted attribute values in CSS selectors. The are quite a few...

> I have an open ticket with GitHub regarding this, which I will cross-link. That was actually closed. I've reopened it. But cross-linking with GitHub tickets doesn't seem to work...

I posted an update here but it has vanished or been deleted. So here it is again, roughly. The below is a quote. ------------ From the two run examples you...