JakeQZ

Results 217 comments of JakeQZ

> move selector precedence calculation to a separate class Possibly using PHP's [Comparable](https://wiki.php.net/rfc/comparable) `interface`. Oh...

We should reorder the tests in `CssInlinerTest` based on functionality being tested - e.g. related to CSS parsing, converting selectors to XPath, ranking selector precedence, merging CSS properties, or various...

> This will help us identify areas for refactoring. Or which tests already should belong elsewhere.

Is there any reason to drop support for an EOL PHP version if it has no issues or lack of language features we want to make use of moving forwards?...

> We don't have to stick to PHP's release cycle. Also, if we make a realease which only adds support for a new PHP version, and doesn't drop support for...

Added blocked label. Rationale for the need to do this is required to unblock :)

The main issue here is to be able to use PHPUnit 10.x. We can't do that without ditching PHP 7.3. It is a shame that PHPUnit does not support a...

See also #1206 and #1207.

Changing milestone to 'backlog' on basis of comments here and in #1242. We will drop support for older versions as and when we need to, but won't plan to do...

> (Not sure why I've only just got the linked build report for a commit several days ago nor why it wasn't picked up by CI tests.) Oh, we have...