JakeQZ

Results 217 comments of JakeQZ

I just spotted the dxsleyia test in the title.

> I'd prefer to to have the data provider directly above the first test that uses is to reduce scrolling. Agree. Though In an ideal world where classes are small,...

Some tests do fail with strict parsing, because they have deliberately invalid constructs. So this is not as easy to achieve as it might sound. However, there is already a...

For now, I'm adding the naming convention of a filename starting with `=` meaning the test should be run with the 'strict' option...

After #460, #461, #462 and #463 are resolved, this will become a non-issue. I only added it to avoid a repeat of something like #352 which manifested as a BC....

Also (though this is probably more for maintainers and collaborators), for PRs that (possibly indirectly) change coding style and guidance, or the set of developer tools and how they are...

> Other things to mention in the guidelines: > > > In general, please always use the third person for the first sentence of a method documentation comment: "(This method)...

> > Examples would help for this one. > This suggestion was originally posted by @oliverklee in [#545 (comment)](https://github.com/MyIntervals/PHP-CSS-Parser/pull/545#discussion_r1644011198). I referenced it here as I felt this could be a...

Looking at the class hierarchy, `Color` extends `CSSFunction` extends `ValueList` extends `Value`. But a named colour would be neither a `CSSFunction` nor a `ValueList` - though would be a `Color`....

> Not sure how best to reconcile this. Maybe the named colour class type would need to be quite separate in the class inheritance hierarchy, focusing more on how it...