JMS55

Results 362 comments of JMS55

Is this structured in such a way that you could eventually pull out panes from groups and move them to other areas? I believe so, but want to double check.

Some thoughts on the user API: * I think I'd like to stick to the old GenerateEnvironmentMapLight name rather than FilteredEnvironmentMapLight. * Similarly, we should give users control over when...

![image](https://github.com/user-attachments/assets/e9cbf938-f35e-4fd6-97a4-73781b358422) Ran it through NSight. 1. `0.17 * 6 = 1.02ms` of vkCmdCopyBufferToImages 😬 2. 0.05ms vkCmdCopyImage that I believe is from this PR (no labels 😢) 3. 0.03ms for...

Based on the shader profiler, the reason irradiance map is performing poorly is the giant switch statement absolutely kills perf as every thread gets masked out. Should 100% index into...

Oh, I see that you're also doing a separate dispatch per mip for the radiance pass. Does each level depend on the previous?

Btw is there any limitations/requirements on input cubemap sizes beyond being a power of 2? I know SPD has a max texture size of like 4k/8k iirc.

Oh another thought, what size are the output cubemaps? We may want to make it configurable between 128/256/512.

Far from critical, but it would be worth considering how to support Nvidia's SER https://registry.khronos.org/vulkan/specs/latest/man/html/VK_NV_ray_tracing_invocation_reorder.html. Additionally there's two very exciting new RT features coming to Nvidia GPUs soon (No API...