JMS55 comments

Results 362 comments of


                                            JMS55

Support separate background and foreground color on UI text

Is this completed by #7596 ?

Ray Tracing Support

* It has to be a separate feature (sadly), as I don't think DX12/Metal support it either * TLAS is required to be built with the `VK_BUILD_ACCELERATION_STRUCTURE_ALLOW_DATA_ACCESS_KHR` flag. wgpu/naga is...

Mesh Shaders

I'm not a wgpu maintainer, and can't help implement it, but I'd be happy to help test it out if you do implement mesh shaders. It's a feature I've been...

Allow customization of shadow-pass vertex shader

The prepass ran into a similar issue for normals. The solution was to add extra (optional) methods to Material for getting prepass-specific vertex and fragment shaders.

Add Distance Fog support

1. I would remove the Off variant, and make the component not-added by default. 3. I would go with the more verbose option, something like DistanceFogSettings (and DistanceFogPlugin). In general,...

Fix bloom alpha handling

After some discussion, this probably needs further thought. I probably shouldn't be using the previous alpha when downsampling or upsampling, it should probably only be during the final step. And...

Fix bloom alpha handling

Closing as I am revamping bloom in a future PR.

Update Gulp; Remove Yarn; Add Godot icons

Oh, I also forgot to mention * [License for godot icon](https://github.com/godotengine/godot/blob/master/LOGO_LICENSE.md), may need attribution * [License for other icons added](https://github.com/godotengine/godot/blob/master/LICENSE.txt)

Request for ".s" and ".S" extension icon

This issue can be closed, .s and .S were added sometime in the past.

Override QueryIter::fold to port Query::for_each perf gains to select Iterator combinators

Changelog needs updating btw. Also, this is the first I'm hearing of it, but using for_each() instead for `for x in query` is faster?