JMS55

Results 362 comments of JMS55

Something else we could try: Do 1-2 samples, and if entirely unshadowded, skip further sampling for performance reasons.

I don't think we ever added ShadowFilteringMethod to the Camera3dBundle by default. We should probably do that.

> I don't think we ever added ShadowFilteringMethod to the Camera3dBundle by default. We should probably do that. I remember why I never did that. `ShadowFilteringMethod` is part of bevy_pbr...

I'm not sure there's any significant blockers left on this PR. If you ran into issues before, can you see if you can reproduce them still? I'd love to get...

I believe I've now resolved all of the issues besides the cascade blending/softening stuff. One way we may be able to fix it is scale the PCF kernel/radius size based...

Probably better idea: Do PCF in world-space

Is this a C-Breaking-Change since it adjusts how shadows look by default?

Yeah a free function for 1. is probably better. Whatever syntax ends up best, but you get the basic idea. For 2. I feel the same. It does feel like...

I like keeping the public API with the full name, but it's totally fine to shorten the internal type names. I did the same for TAA and SSAO. We may...