Julien Enoch

Results 98 comments of Julien Enoch

Hi @luca-della-vedova, This is still on our roadmap, but not for short term (i.e. at least not for the next 3 months). We are still thinking about the options we...

Such publication can be made on zenoh, on DDS or on both. A publication on zenoh has almost no cost if there is no subscriber. I suggest to not make...

This new build is failing because CycloneDDS 0.7 fails to build for this target. See https://github.com/eclipse-zenoh/zenoh-plugin-dds/actions/runs/3142803509/jobs/5106994126#step:6:455 : ```log /Users/runner/work/zenoh-plugin-dds/zenoh-plugin-dds/target/aarch64-apple-darwin/release/build/cyclors-3a940d119d43705c/out/cyclonedds-build/include/dds/ddsi/q_thread.h:122:8: error: thread-local storage is not supported for the current target thread...

Digging into the code, I see this completion with `0`s of short commit id comes from usage of `git2::Oid::from_str(s)` in [`SourceId::precise_git_oid()`](https://github.com/rust-lang/cargo/blame/363a2d11320faf531f6aacd1ea067c6bc08343b9/src/cargo/core/source_id.rs#L469). It somehow ends up to be used in [`github_fast_path()`](https://github.com/rust-lang/cargo/blame/363a2d11320faf531f6aacd1ea067c6bc08343b9/src/cargo/sources/git/utils.rs#L1466),...

> One fix I can think of is comparing if the value of --precise is a hex string of 40/64 characters [here](https://github.com/rust-lang/cargo/blob/363a2d11320faf531f6aacd1ea067c6bc08343b9/src/cargo/ops/cargo_generate_lockfile.rs#L112), and give a nice error if not. If...

Understood, that makes sense. I think the root of the issue is that the conversion from short SHA to `git2::Oid` leads to a 20 bytes SHA completed with `0`s that...

> BTW, I accidentally have a working patch of this during code exploration. I may post a PR later but feel free to propose more better solutions :) You PR...

Hi @nazmicancalik, You correctly analyzed the problem: for efficiency and simplicity concerns, the bridge creates only 1 DDS Reader or Writer per Topic. The QoS used for those creations depend...

> Is the reliability at the time of creation of a reliable subscriber actually relevant? It seems as its only possible to drop msgs if an unreliable qos exists and...