IceSentry

Results 241 comments of IceSentry

So, the implementation seems good to me, but I'm not sure I understand _why_ this is necessary. Isn't the Image render target just a wrapper around targetting a TextureView? As...

Alright, makes sense. In that case this PR seems fine.

~~If it's a first party integration, there should also be some way to sync the environment map light texture with the skybox.~~ It's already mentioned, I somehow skipped that part...

I _really_ like 1. Although, I'd probably suggest making it a free function that takes a `&mut App` because I don't really like the idea of adding an extension to...

> almost every usage of the engine will need randomness I think that's the part that's not as obvious as you are saying. There's plenty of projects that _don't_ need...

There's 165 files with .rs extension in the examples folder and only 15 of those use rand and half of those are for stress tests. In most cases rand is...

So, I wasn't aware of this PR and I think the merged api should have been different. I'd like to suggest it here first to see what people think and...

If we decide to keep this api, please consider adding a migration guide section to the PR description.

I don't think this was caused by this PR. It's also broken when using DX12 on the commit before this PR. The issue seems to be be with the DX12...

I went back to https://github.com/bevyengine/bevy/pull/9796 and it's still broken when using DX12 for me. Back to f69e923c270fbc7eb57cc4424aa16b8802af3dd2 and it still doesn't work correctly.