IceSentry

Results 241 comments of IceSentry

One way to keep semver would be to keep the api and add a new one with bools. Maybe even tag the broken one as deprecated, but I'm not sure...

Yes, but I decided to keep the grab terminology to stay closer to winit. Would you say it's better to keep it named `grab_mode` instead of `grabbed`?

I reintroduced the api, but I modified the implementation a bit to avoid the error. This means that we technically don't need the boolean api, and this gives a tiny...

Updated to _only_ use the fixed api and don't introduce a new api or remove anything.

I updated the title and changed the docs a little bit to reflect that it's possible that the getter will return a value that is different from the one sent...

Which commit is that? This PR shouldn't have any breaking commit.

Oh, is the issue that I made this PR from main? If that's the case then yeah the 0.9.1 release will only cherry pick this PR.

After a bit more investigation, it seems to be that `CursorGrabMode::Locked` is not supported, but `CursorGrabMode::Confined` is. This should probably be documented somewhere since it seems it falls back to...

To add a bit more detail, `CursorGrabMode::Locked` is supported in macOS but not Windows, `CursorGrabMode::Confined` is supported by windows but not macOS. On windows setting it to `Locked` will silently...

My current fix is semver compatible and uses the recommended approach from winit so it could be in 0.9.1. At the very least I think we should update the docs...