IceSentry

Results 241 comments of IceSentry

Please add a code snippet in the migration guide. Something like ```rust // 0.12 #[derive(Default)] struct PostProcessNode; impl PostProcessNode { pub const NAME: &'static str = "post_process"; } // 0.13...

> Last but not least, there are many inconsistent namings, like in Labels3d: Prepass, EndPrepasses, StartMainPass, is it with or without start and end and is it plural or singular?...

Well, there's the "normal prepass" as in the prepass that generates a normals texture and there's the "depth prepass", but both are in the same Prepass node

My opinion is that calling it `Prepass` is good enough. That or _maybe_ `DepthNormalPrepass`, but I'd prefer just calling it `Prepass`. Currently most rendering contributors are already familiar with this...

This was done in this PR https://github.com/tokio-rs/tracing/pull/2225 but for reasons I don't know tracing-appender hasn't been released in over a year.

> Seems related to https://github.com/tokio-rs/tracing/issues/2701 too I'm not sure that would solve that issue. A custom extension would still use the date time stamp in the middle like `debug.2023-09-13.log`

After some discussions on discord, we realized that just using a custom node is not enough and this would need a separate camera. Since this is a bit more involved,...

I'm not sure I understand your comment about asset preprocessing. Isn't the point of this to be able to recompute AABBs on runtime meshes? Spawning a mesh will already create...

Does it just crash or do you mean that it still compiles synchronously?

@JMS55 > A bit surprised that the water reflection from the envmap is part of SSR, and not just part of the PBR shader, but maybe there's a good reason...