IceSentry

Results 241 comments of IceSentry

Did you commit the right thing? I'm not sure the code is related to adding a new Color

Looks like I should use expect here and just log the errors. I'll update my PR soon.

Okay, so this generates a bunch of errors now, but it just generates a bunch RenderCommandFailure. So I'll need to also bubble up what those failures are. The main issue...

I added a skip variant to `RenderCommandResult` because that's how it's used every where. I also added a new Failure variant with a message so we can log real failures...

> you kept 3 expect, is it... expected? ~~Yes and no, it's possible I missed one, but also, I want this PR to mostly keep the previous behaviour and we...

waiting on https://github.com/bevyengine/bevy/pull/13069 to be merged so I can clean up this PR

Yeah, that makes sense. It would be ideal if it was completely automated but I don't think that's possible

https://github.com/gfx-rs/gfx/issues/3219 mentions that the api could potentially be based on WebXR which means it could also target the web without needing a native and web extension

For the record, there's some work being done in this PR https://github.com/bevyengine/bevy/pull/2319 to support XR in bevy