Johannes Schneider

Results 156 comments of Johannes Schneider

I believe this will go a way once use dynamic rendering in rendergraph2, so I am not sure if it's worth looking into this any further.

Hey Bojack Thank you very much! Ofc you can :) @yeetari proposed to make it optional though by introducing a CMake profile or CMake option. Are you on our Discord?...

Yes, pls make a pull request :) I will work on fixing the warnings.

A book by John Lakos called "C++ Allocators for the Working Programmer" will be released this year. This will help us a lot.

Another title for this issue could be "allow vsync to be turned off again".

We should also run the tests in the CI, but not the benchmarks. Keep in mind that our tests don't require a gpu to run!

```cpp template class GPUMemoryBuffer { protected: const Device &m_device; VkBuffer m_buffer{VK_NULL_HANDLE}; VmaAllocation m_alloc{VK_NULL_HANDLE}; VmaAllocationInfo m_alloc_info{}; std::string m_name; public: /// Construct the GPU memory buffer without specifying the actual data to...

For example, this is part of our current staging buffer code: ```cpp [[nodiscard]] VkBuffer create_staging_buffer(const void *data, const VkDeviceSize data_size, const std::string &name) const { // Create a staging buffer...

I was experimenting with new code during the rendergraph refactoring, but I decided it's too much code to touch in one pull request, so this will be a separate refactoring...

We could set the `VkBufferUsageFlags` and `VmaMemoryUsage` parameter of `GPUMemoryBuffer` nicely by accepting something like a buffer usage parameter in the `GPUMemoryConstructor` (the rendergraph does something similar). Something like |...