Enable -Wall and -Wextra flags through CMake by default

[IAmNotHanni]

Is your feature request related to a problem?

There are some warnings which we don't see because the -Wall and -Wextra flags are not enabed by default.

Description

Pass -Wall and -Wextra through CMake by default.

Alternatives

Do not enable those flags.

Affected Code

The entire project.

Operating System

All operating systems.

Additional Context

none

[Denisthatorf]

I want to help with this one. Can I try it ?

[IAmNotHanni]

Hey Bojack Thank you very much! Ofc you can :) @yeetari proposed to make it optional though by introducing a CMake profile or CMake option. Are you on our Discord?

best regards Johannes

[Denisthatorf]

Not yet

[Denisthatorf]

So with -Wall and -Wextra flags, I get a ton of extra messages. I think it is very smart to make it an INEXOR_BUILD_WITH_CHECK option with the default state OFF. Is it okay if I try to commit it?

[IAmNotHanni]

Yes, pls make a pull request :) I will work on fixing the warnings.