Howard Braham

Results 12 comments of Howard Braham

@SeraphimRP this is good work, but can you bisect it into the actual commits inside PR 7004? That would help me narrow it down further. (https://github.com/MetaMask/metamask-extension/pull/7004/commits) The cause of this...

This is now fixed, and should come out in the next release. We just solved it by blocking Battle.net, but here's the actual problem if you're curious: - The page...

Should we add the package `[email protected]` as part of this PR?

1. Let's centralize those selectors, you're repeating some of the same ones in 3 places already. Create `/test/e2e/helpers/selectors.ts` and import from there. 2. This is an optional challenge, but it...

I was thinking about what Mark Stacey said today with our very large CircleCI usage. In that context, it makes sense to combine and form larger tests. I tried, and...

@karnie6 thanks for your contribution. Please tell me why you think this is a better zkSync Block Explorer URL. Please give official documentation, if available.

This is very very interesting, but I have a few questions: - Under what circumstances would you want to override the included proxy at `127.0.0.1:8000`? - `SELENIUM_HEADLESS` fails on a...

@Gudahtt Chrome and Chromedriver automatically get updated to the latest stable version because of #21481

I don't think this GitHub Action would run at the correct time. It's set to run only on `master` and `develop`. I believe it needs to run on any branch....