metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Updating zkSync Block Explorer URL

Open karnie6 opened this issue 1 year ago • 6 comments

Description

Related issues

Fixes: N/A

Manual testing steps

  1. Go to metamask
  2. Switch your network to zkSync ERA
  3. Click on the ... button on the top right and click on "View on Explorer". Ensure it redirects to era.zksync.network.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

karnie6 avatar Feb 06 '24 21:02 karnie6

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 06 '24 21:02 github-actions[bot]

@karnie6 thanks for your contribution. Please tell me why you think this is a better zkSync Block Explorer URL. Please give official documentation, if available.

HowardBraham avatar Feb 06 '24 23:02 HowardBraham

I have read the CLA Document and I hereby sign the CLA

karnie6 avatar Feb 07 '24 03:02 karnie6

@karnie6 thanks for your contribution. Please tell me why you think this is a better zkSync Block Explorer URL. Please give official documentation, if available.

Hi @HowardBraham - I work at Matter Labs, the team behind zkSync. We recently launched Etherscan for zkSync at the new URL (era.zksync.network). here's the official announcement: https://twitter.com/zksync/status/1744343401057710096?s=20 . Etherscan is the gold standard for Ethereum devs and users, and any references to block explorers across the broader ecosystem should point to the Etherscan URL.

karnie6 avatar Feb 07 '24 03:02 karnie6

Can we hold on approval of this PR. Want to double-confirm with the team on our plans here. Will update this PR in the next day.

karnie6 avatar Feb 07 '24 13:02 karnie6

hey @karnie6 thank you for your contribution, can you pls add a recorded video before/after. we expect to see for example all the incoming transactions on the activity tab for example

salimtb avatar Feb 14 '24 15:02 salimtb

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions[bot] avatar Apr 14 '24 18:04 github-actions[bot]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

github-actions[bot] avatar Apr 28 '24 20:04 github-actions[bot]