metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

ci(action): GH action to validate PR title against conventional commit standard

Open sethkfman opened this issue 2 years ago • 14 comments

Description

Added a GH action step to validate the PR title against the Conventional Commit standard https://www.conventionalcommits.org/en/v1.0.0/

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

sethkfman avatar May 19 '23 16:05 sethkfman

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 19 '23 16:05 github-actions[bot]

Builds ready [5d8bc08]
Page Load Metrics (1658 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint96172124199
domContentLoaded14831933164111455
load14831933165811957
domInteractive14831932164111455
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

metamaskbot avatar May 19 '23 17:05 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ef9e63a) 68.48% compared to head (540349d) 68.48%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #19229   +/-   ##
========================================
  Coverage    68.48%   68.48%           
========================================
  Files         1089     1089           
  Lines        43015    43015           
  Branches     11462    11462           
========================================
  Hits         29455    29455           
  Misses       13560    13560

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 19 '23 17:05 codecov[bot]

Builds ready [6386423]
Page Load Metrics (1531 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint104149125136
domContentLoaded1419171915317637
load1419171915317637
domInteractive1419171915317637
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

metamaskbot avatar Jun 22 '23 17:06 metamaskbot

I will do so within the next day or two and push a commit to this branch

so I did not do that within a day or two

danjm avatar Jul 21 '23 12:07 danjm

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions[bot] avatar Sep 19 '23 14:09 github-actions[bot]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

github-actions[bot] avatar Oct 03 '23 14:10 github-actions[bot]

I don't think this GitHub Action would run at the correct time. It's set to run only on master and develop. I believe it needs to run on any branch.

Also, let's update the library to 5.4.0

HowardBraham avatar Feb 06 '24 21:02 HowardBraham

Builds ready [292e1c3]
Page Load Metrics (769 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81151106168
domContentLoaded9452084
load6718487694923
domInteractive9452084
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 06 '24 22:02 metamaskbot

Builds ready [c38f13f]
Page Load Metrics (836 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint801611152311
domContentLoaded106324157
load7529448365727
domInteractive106324157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 07 '24 20:02 metamaskbot

@danjm @brad-decker Someone with admin access needs to add amannn/[email protected] to the allowed actions for this PR to work

HowardBraham avatar Feb 07 '24 22:02 HowardBraham

Builds ready [8655319]
Page Load Metrics (901 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint873261216230
domContentLoaded97118189
load7401552901252121
domInteractive97118189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 08 '24 01:02 metamaskbot

Builds ready [f4bc43e]
Page Load Metrics (953 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1122771803718
domContentLoaded969252211
load815139395312460
domInteractive969252211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 14 '24 22:02 metamaskbot

Builds ready [927c314]
Page Load Metrics (1027 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1123372004220
domContentLoaded1697372713
load913111910275727
domInteractive1697372713
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 16 '24 23:02 metamaskbot

Builds ready [540349d]
Page Load Metrics (1062 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1123712046330
domContentLoaded15119442713
load8751295106211555
domInteractive15119442713
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 19 '24 20:02 metamaskbot

Is this working?

davidmurdoch avatar Feb 27 '24 15:02 davidmurdoch

@davidmurdoch I think you're right, I think it's not working 100% of the time. Some of this may be PRs that were opened before this merged.

EDIT: I think I know... it only runs on [opened, edited, reopened]. So it won't catch an old PR until you edit the title. This also may be acceptable.

HowardBraham avatar Feb 27 '24 16:02 HowardBraham