metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

ci(OOM): bump resource size on prep-build-storybook and test-storybook

Open HowardBraham opened this issue 1 year ago • 2 comments

Description

#22843 went a little too far to reduce CircleCI credits (this was kind of expected, as we were being aggressive)

prep-build-storybook and test-storybook are now crashing frequently from OOM errors

This PR bumps the resource size on prep-build-storybook and test-storybook back to large

Related issues

Partial undo of #22843

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've clearly explained what problem this PR is solving and how it is solved.
  • [x] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [x] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

HowardBraham avatar Feb 15 '24 00:02 HowardBraham

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 15 '24 00:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3d38143) 68.54% compared to head (ad943ce) 68.54%. Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22965   +/-   ##
========================================
  Coverage    68.54%   68.54%           
========================================
  Files         1088     1088           
  Lines        42908    42908           
  Branches     11414    11414           
========================================
  Hits         29410    29410           
  Misses       13498    13498           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 15 '24 00:02 codecov[bot]

Closed in favor of #22975

HowardBraham avatar Feb 15 '24 20:02 HowardBraham