anchor icon indicating copy to clipboard operation
anchor copied to clipboard

feat: ata create idempotent and drop rent

Open Arrowana opened this issue 3 years ago • 1 comments

I think there is no need to tangle init_if_needed on an ata with this

The validation looks the same though, but it will be odd to check if it exists, and when it does not still call create idempotent. https://github.com/solana-labs/solana-program-library/blob/84c566b13e55579aeb291aefa3866faac67e2dfc/associated-token-account/program/src/processor.rs#L92-L107

Arrowana avatar Aug 26 '22 01:08 Arrowana

@Arrowana is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 26 '22 01:08 vercel[bot]

Would like to merge but having trouble fixing the merge conflicts on the command line

  • any conflicts in cargo.lock and spl/cargo.toml should both be the reverted to the current anchor master versions of the differences
  • Can't quite parse where the conflict is coming from in associated_token.rs whether it's just because of the new code or if there's been an update to the file in master since this PR was created. If possible please modify and resolve the conflict. Thanks!

The removed rent shouldn't be breaking to anyone because it's hidden inside the macros right?

Henry-E avatar Nov 16 '22 16:11 Henry-E

I removed the changes to the cargo.lock and cargo.toml since we already updated to the latest versions of in previous commits.

Henry-E avatar Dec 05 '22 16:12 Henry-E

Thanks for finishing this!

Arrowana avatar Dec 05 '22 20:12 Arrowana