Hans Mackowiak

Similfy MagicColor stuff

11

Right now, there are multiple ways of Colors being stored: * as Byte (mutable) * as String (short/long) * as Enum (`MagicColor.Color`, not really used?) * as ColorSet(immutable, Iterable Byte,...

https://github.com/Card-Forge/forge/blob/db24b1bf97766089c0cedf779f70e2b266b9d6dd/forge-gui/src/main/java/forge/itemmanager/ColumnDef.java#L273-L275 `toDeckColor` can return null if it is not a DeckProxy, and then getOrderWeight does fail

Dependency Layer 6

1

addChangedCardTraits - [x] StaticAbilityContinous - [x] MANABOND CounterType (playtest) #7010 - [ ] AnimateEffectBase - [x] Suspected (Can't Block) #6990 - [ ] PlayerKeywords - [ ] PerpetualAbilities #9241 addChangedCardKeywords...

Dependency Layer 4

1

Places that use addChangedCardTypes to be changed for Layer 4 using this as LinkedHashMap: - [x] StaticAbilityContinuous - [x] MANABOND CounterType (playtest) #7010 - [ ] Bestow (Add Aura Type...

Perpetual Effects should be changed into Hidden Statics, so while still applying, they use Layer System. The outliner is ManaCost changes for `Thought Partition` and Incorporate. It needs to apply...

In ApiFactory, the cost is defined there https://github.com/Card-Forge/forge/blob/b74c0b178f85b33db58a0c520c50e314bbb65a8a/forge-game/src/main/java/forge/game/ability/AbilityFactory.java#L190-L193 Using the State ManaCost. But what if we let it pass `null` and then, later in the Spell Class, have it fall...

Show Mayhem in flashback zone

1

@tool4ever this shows Mayhem in the Flashback zone or does it need better logic?

Cleave: turn it into a keyword

1

Closes #7686 This is the Mechanical Part, the Desc Part with cut [] will be added soon to this MR

Investigate possible crashes in CardRules without exception

1

If for some Reason, the Game crashes inside the CardRules Constructor (like yesterday with the Android bug) https://github.com/Card-Forge/forge/blob/8c2c32a3d898d38c1469e07c8a05c46ac558c97d/forge-core/src/main/java/forge/card/CardRules.java#L61-L91 Case A: While loading all the cards from Cardfolder.zip, then the Exception...

Fixed dungeons images fetch

3

> Fixed dungeons images fetch I need to fix that in a different MR Because the ImageFetch is the wrong place to get the Dungeon type _Originally posted by @Hanmac...