Card-Forge
Fixed dungeons images fetch
Fixed dungeons images fetch
I need to fix that in a different MR Because the ImageFetch is the wrong place to get the Dungeon type
Originally posted by @Hanmac in https://github.com/Card-Forge/forge/issues/7921#issuecomment-3186901920
Part of this Issue to be addressed:
- DUNGEONS("dungeons") section isn't really needed? Or is it?
- Or should they be moved to Other section?
- (Dungeon use T on their Card, i might move the Dungeons to TokenScripts?)
Venture Effect uses to iterate over all Variant Cards https://github.com/Card-Forge/forge/blob/599a6290680f9b154dbeaef64ba37b992dce707d/forge-game/src/main/java/forge/game/ability/effects/VentureEffect.java#L48-L58 if we are specifically looking for Dungeons, we might use better ways than that?
I would like to update the pattern and tokenPattern to use named captures:
"^(?:(?<cnum>.?[0-9A-Z-]+\\S?[A-Z]*)\\s)?(?:(?<rarity>[SCURML])\\s)?(?<name>[^@\\$]+?)(?: @(?<artist>[^$]+?))?(?: \\$(?<vname>.+))?$"
if we change the Regexp Pattern, we might look into this Issue with FlavorNames #8281
