Hans Mackowiak

[Serializer] Context Options on how numeric/float are normalized to XML

1

### Description Currently scalar numeric values are passed directly to the Encoders which is then formatted into string: https://github.com/symfony/symfony/blob/3711a6a5e1d09a8b04eb62f228faa1e0b290745f/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php#L463-L464 for the xml i am working on, i would like to...

Update Mage_SalesRule_Model_Quote_Discount

3

### Description (*) * DiscountDescription should only be string or null (not array) * strlen needs a type check for string before * sales_quote_address_discount_item needs to be done after calculator->process...

removeRequestParam called by setBeforeAuthUrl messed up Query if ___SID is used

1

### Preconditions (*) 1. OpenMage 20.3, but older should be affected too 2. ### Steps to reproduce (*) 1. `Mage::getSingleton('customer/session')->setBeforeAuthUrl($this->getRequest()->getRequestUri());` while having `___SID=S` as Query, because some other Mage function...

Make Mage_GiftMessage optional in templates

9

### Description (*) This makes all templates use functions in their blocks to check `isModuleEnabled('Mage_GiftMessage')` first ### Related Pull Requests ### Fixed Issues (if relevant) 1. Fixes OpenMage/magento-lts#4263 ### Manual...

Mage_GiftMessage shouldn't be required for Mage_Adminhtml

2

### Preconditions (*) 1. should be all versions 2. ### Steps to reproduce (*) 1. have Mage_Giftmessage be disabled via etc/modules 2. Open an existing Sales/Order ### Expected result (*)...

AI needs better logic for Room Spells: it should only cast or unlock a Room when their Unlock Trigger is positive right now, it doesn't have extra UnlockAI class some...

FCollection View vs unmodifiable vs Immutable Refactor

8

Currently the FCollection View sits in the FCollection Class and doesn't implement either java Collection or java List so each time we get a View and want to iterate over...

Migrate guava Function/Predicate to java

8

These functions are Legacy: ```java import com.google.common.base.Function; import com.google.common.base.Predicate; ``` use these instead ```java import java.util.function.Function; import java.util.function.Predicate; ``` If possible, try to remove the usage of anonymous classes with...

Can't Untap effects needs to be rewritten, some could be Statics, some could be SpellAbilityEffects. Different Cases: - [ ] Keyword `CARDNAME doesn't untap during your untap step.` → Static...

AttackRestriction needs to be reworked too, they should not rely on AttackRestrictionType enum. - [ ] CARDNAME can only attack alone. - [ ] CARDNAME can't attack unless a creature...