Graham

Results 105 comments of Graham

Debugging through, I can see that the issue is indeed introduced here: https://github.com/icsharpcode/CodeConverter/blob/068c7dd9ec06ec32d51794bfd2f0e0c40fb7114e/CodeConverter/Shared/DocumentExtensions.cs#L110-L112 This looks like a bug in roslyn. I'll try to repro purely against that library and file/fix...

I did make an attempt at reproing within roslyn, but got bogged down by trying to find an existing type of test to fit this in with and ran out...

It looks like all future VB development will ["focus on stability"](https://devblogs.microsoft.com/vbteam/visual-basic-support-planned-for-net-5-0/), so VB probably isn't getting the improved select case feature. Therefore I think we'll have to transform to an...

Thanks both, looks like there are a few things to fix here! 1. The pre-initialization of the ref parameter before calling should go from `TestStruct argstructParam = null` to `TestStruct...

Ah yes, nice one, I can see DecimalConstant in the [decompilation of that VB](https://sharplab.io/#v2:DYLgbgRgNAJiDUAfAkgWwA4HsBOAXAzgAQDKAnvrgKaoCwAUAAoCuEwAlgMaEDCwAhviLd6DbGzB8qJABZ9slGCRaEA8ulxtMAOz7AGcvqnwAKAJT1ClwgDEmWjhu0B1NrmlrHOvQaNn6AUS1FYhZ6C1FxSUoZOQUlCBs7B00tFzcPFN19bEMTDO1dQgAhUgAlSgAzQgpsJgdsw0IAQSIAFUoKYlxah0IAXkIAOUw3Ni0AcyhVdUzgYrLKwhhKDjZULJ9mogARFbXCgYAGADoAZhhzOitq7rrcBtR+ocoAd0J2ztuHCytl1fXvDlHkcLIFgqE6PRrGJKEESF9cEx5O8Orguj1cD9LNC2LDFE0tsVMJhgJQ+FoAnD0XckZRKYpeAJ8EA=), but there's no struct equivalent. For the ordering issue, one solution would be to make `nonRef`...

Hopefully using AddExplicitConversion with isConst=true will deal with those sorts of issues: https://github.com/icsharpcode/CodeConverter/blob/master/CodeConverter/CSharp/TypeConversionAnalyzer.cs#L49

Thanks for the report. There are a bunch of general hints in the [contributing](https://github.com/icsharpcode/CodeConverter/blob/master/.github/CONTRIBUTING.md) file. I'd suggest turning the bug report example into a test case and then debug into...

Thanks for raising this. It is indeed a tricky area. I'd be interested to see more of the details of VB's async leniency. Sometimes these things can be "fixed" during...

Thanks. The case of something that works due to lenience in VB, but not in c# is the case I'm interested in. E.g. Does VB add an await automatically somewhere....

Next steps on this are to have a look at whether the equals operator in VB linq does the same as outside of linq, and whether we could detect a...