Graham

Results 105 comments of Graham

I think most people don't put labels in their code, so a special case when they're present to pull declarations before the first label seems sensible.

You're the first person to ask! I don't have a mac so it's not been tested. I'd be happy to work with you on seeing if we can make it...

I've just tested this on a brand new kali linux install within WSL. Trying to convert a brand new helloworld vb console app I got type load when it tried...

Thanks for the extra info. I think you should be able to see windows test results here (linked from the readme via the green badge) https://icsharpcode.visualstudio.com/icsharpcode-pipelines/_build/results?buildId=1627&view=ms.vss-test-web.build-test-results-tab > Total tests: 681...

Good point. It definitely relies on msbuild minimum. But I haven't tried with only that, nor documented it as a requirement 👍

Yes, 2017 is the absolute minimum (and even that has had issues for some machines without recent dot net runtime installed) . It's configured not to install on prior versions...

Ah, did you get that error from running the command line perhaps? That just tries to use the latest installed version of VS and msbuild assemblies

Thanks for the report - changes to output logic like this are indeed high priority to fix. I can't reproduce the erroneous output in the VS extension or the web...

Thanks both. The "simplification" stage is mostly just a call to the codeanalysis (AKA roslyn) library, so the Visual Studio version can have an impact. I'll try with the latest...

Thanks for that, I can confirm that changing the setting does allow me to reproduce the issue converting the example I gave here: https://github.com/icsharpcode/CodeConverter/issues/823#issuecomment-1027472414 (using VisualStudio.17.Preview/17.1.0-pre.1.1+31911.260 in case it turns...