Guillaume Giudicelli
Guillaume Giudicelli
Love it. Determining the inheritance tree can be done by parsing headers, as is done for determining the children classes. It's not super robust for templated classes though
Test failures unrelated. See comments in https://github.com/idaholab/moose/pull/30592 for anyone reviewing this
NS stuff dropped by rebasing
@joshuahansel if you want to take a look, same changes but in their own PR
Test failures (threaded eigen problem notably) unrelated
Please remove the merge commit and use a rebase instead Also I think the gold files are checked in and modified in two different commits in the beginning. Is that...
let's squash commit 4 into commit 3 and have a descriptive commit message please
reaching out to @lindsayad for the merge since he's assigned
> How do you want to set the threshold? Experimentally? Start too low and raise it over time > If we don't find similar posts above this threshold, what should...
Comments sent on slack (machine on which I reviewed is staying in France and did not submit it)