moose icon indicating copy to clipboard operation
moose copied to clipboard

Add support for linear system convergence

Open GiudGiud opened this issue 8 months ago • 6 comments

builds on top of https://github.com/idaholab/moose/pull/30592

also fixes problems with physics exodus restart, and iteration adaptive DT with linear systems

GiudGiud avatar Jun 03 '25 15:06 GiudGiud

Job Documentation, step Docs: sync website on 6bf3495 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Jun 03 '25 18:06 moosebuild

Test failures unrelated. See comments in https://github.com/idaholab/moose/pull/30592 for anyone reviewing this

GiudGiud avatar Jun 04 '25 04:06 GiudGiud

NS stuff dropped by rebasing

GiudGiud avatar Jun 05 '25 20:06 GiudGiud

Job Precheck, step Clang format on 54a2ea7 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/30653/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 5aa7c7ef1f2856c4fc51a29e3d329f6c5112dac2

moosebuild avatar Jun 05 '25 21:06 moosebuild

Job Coverage, step Generate coverage on 0b6bffa wanted to post the following:

Framework coverage

6a5ef1 #30653 0b6bff
Total Total +/- New
Rate 85.50% 85.50% +0.00% 82.67%
Hits 113135 113183 +48 62
Misses 19186 19193 +7 13

Diff coverage report

Full coverage report

Modules coverage

Fluid properties

6a5ef1 #30653 0b6bff
Total Total +/- New
Rate 86.00% 86.01% +0.01% -
Hits 8168 8169 +1 0
Misses 1330 1329 -1 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 82.67% is less than the suggested 90.0%

This comment will be updated on new commits.

moosebuild avatar Jun 07 '25 02:06 moosebuild

@joshuahansel if you want to take a look, same changes but in their own PR

GiudGiud avatar Jun 22 '25 23:06 GiudGiud

Test failures (threaded eigen problem notably) unrelated

GiudGiud avatar Jun 26 '25 10:06 GiudGiud

Broke valgrind: https://civet.inl.gov/job/2986992/

loganharbour avatar Jun 26 '25 16:06 loganharbour