Guillaume Giudicelli
Guillaume Giudicelli
@tanoret I can try to reproduce the rayleigh-bernard convection input with Physics & linear FV. Is that enough ? Is there a particular flow test bed input you would like...
The results are not a great match for the two test cases between linear and nonlinear. EDIT: fixed! Some differences in how we were doing friction & interpolation fixed, and...
@tanoret or @MengnanLi91 can you please do the technical review / validation?
Agreement with nonlinear FV is quite good now with these changes - extrapolated pressure at the inlet in linear FV - pressure drop computation fix for the pressure face interpolation
Rebased on #30288 which should be merged first
@tanoret the linear FV. two phase mixture will now error with skewed meshes. This should address your concern. BTW, I ran a few single phase cases on skewed meshes without...
@grmnptr did you want to re-review this?
@grmnptr @tanoret last commit is a bug fix on gravity for the flow physics. We should make a decision on this PR so this bug fix makes it in regardless.
> That flux is lagged, while the advected quantity interpolation is treated implicitly. It feels like we have it backwards here. That's out of necessity. Writing the linearization of the...