Guillaume Giudicelli

Results 719 comments of Guillaume Giudicelli

the advantage of interface with a similar design as meshChangedInterface is that it becomes a real moose capability, objects can be made to "do something if mesh displaces". Whereas a...

I think you could do that. I imagine it is to write a FunctorIC object, which would be very flexible Then: - any PP you depend on in an IC...

I don't think I understand why moving a parameter away from the base class and into the derived classes is changing anything? This is a trivial item so if we...

Could you please try this fix instead? line 83 of the`modules/thermal_hydraulics/python/tests/peacock/fluid_property_interrogator/../../../peacock/FluidPropertyInterrogatorPlugin.py` (removing ['default'], since it no longer has a default) ``` if 'fp_type' in params: fp_type = params['fp_type'] if fp_type...

I see the default in the JSON here we probably just need to set a default to the class being used in the test ``` "fp_type": { "basic_type": "String", "controllable":...

all we need to do is add this to SodiumFP to pass the test. ``` params.set("fp_type") = "sodium-specific-fp"; ``` if we want to be 100% resistant to future failures of...

or we can add a default in FluidProperties.C ``` params.addCustomTypeParam("fp_type", "FPType", "Type of the fluid property object"); ``` since the default-setting routine does not exist in FluidProperties.C, we would do...

Alex is babysitting the libmesh update through, let's just stack this one on the next merge