Guillaume Giudicelli comments

Results 719 comments of


                                            Guillaume Giudicelli

Make solid_mechanics moosedocs check clean

no my PR has not been reviewed. I can deal with conflicts I'm not worried if your PR gets merged first

Numerical evaluation of strain energy rate density for creep laws

hello you ll want to rebase this on origin/devel, and only include your commits

Create an automated way of keeping track of whether sparsity pattern should be preserved or not

No I m talking about having those "0 * ad number" operations to preserve the sparsity pattern only for solvers that require it. For example the segregated one does not...

Create an automated way of keeping track of whether sparsity pattern should be preserved or not

Yes. But tie it to the actual need (sparsity pattern preservation) than pointing out specific solvers.

Create an automated way of keeping track of whether sparsity pattern should be preserved or not

Again, this code: ``` if (coef = 0) do average else do what the user requested ``` does not look any better than what we need to have now. The...

Limit number of files to merge together in unity build

This is a good idea. The default size could be chosen based on how much memory one has on their system too, with a rough heuristic.

Linear kepsilon

> 2-Velocity oscillations at the outlet of geometries (see picture below) using the nonlinear model the nonlinear FV? Are these oscillations in the new tests? If not we can create...

Linear kepsilon

Looking at the code, it seems to me that if we put the wall-bounded element in a different block, we could avoid all these map lookups ? @grmnptr @tanoret is...

Linear kepsilon

🎉

K epsilon mods

what is the status of this? I am waiting for this to be merged before the Turbulence physics can be updated with K-Epsilon