Guillaume Giudicelli
Guillaume Giudicelli
the hack with the parsed function would be also necessary for these functions since they rely on an initialSetup after their constructor to be ready for use ``` SolutionFunction.C:SolutionFunction::initialSetup() ImageFunction.C:ImageFunction::initialSetup()...
I ll squash those commits when addressing the reviews
Thanks for the review! And thanks to @muelcm for bringing it to our attention
registerobjectRename will do everything you want. Are you working on a better design?
Not sure it needs to be re-designed. Do you have an input where it fails which you can share with me?
it does do a directional friction flow diode if you use the control system to turn it on and off. The diode is not self-contained in this material, that's true,...
Replacing the THMControl {INITIAL, TIMESTEP_BEGIN} to {INITIAL, TIMESTEP_END} causes a lot of test failures ``` test:controls/pid_control.test ................................................................ FAILED (CRASH) test:controls/dependency.test ................................................................. FAILED (CRASH) test:misc/coupling_mD_flow.coupling_mD_nonoverlapping ........................................ FAILED (ERRMSG) test:controls/delay_control.test ............................................................ FAILED...
for sure. At least before we add the vector limiter options
nah we're almost done
@lindsayad you still involved in moltres?