moose icon indicating copy to clipboard operation
moose copied to clipboard

Propagate harmonic interpolation method option to Navier Stokes

Open GiudGiud opened this issue 3 years ago • 2 comments

refs #21923

No regolds! Our viscosities must be constant over all of NS. This will change with K-eps

This does not touch the mixing length. I dont see a big need to improve it as we ll move to regularized K-epsilon soon

GiudGiud avatar Oct 12 '22 19:10 GiudGiud

Job Documentation on 50c36c6 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Oct 13 '22 02:10 moosebuild

Job Coverage on 50c36c6 wanted to post the following:

Framework coverage

993b03 #22381 50c36c
Total Total +/- New
Rate 84.30% 84.29% -0.01% 31.82%
Hits 80166 80169 +3 7
Misses 14925 14938 +13 15

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

993b03 #22381 50c36c
Total Total +/- New
Rate 85.50% 85.53% +0.02% 85.00%
Hits 9766 9773 +7 17
Misses 1656 1654 -2 3

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 31.82% is less than the suggested 90.0%
  • navier_stokes new line coverage rate 85.00% is less than the suggested 90.0%

This comment will be updated on new commits.

moosebuild avatar Oct 13 '22 03:10 moosebuild

for sure. At least before we add the vector limiter options

GiudGiud avatar Oct 13 '22 21:10 GiudGiud