Allow computation of VFRs on initial

[GiudGiud]

The issue is only with Rhie Chow interpolation (average is fine)

• we need RC UO before VFRs on initial otherwise we hit a missing a functor
• by default, general UOs are after side UOs, this cannot be changed, many tests depend on it
• preaux for RC UO is not great if using auxvariables for advection, let's have a warning
• preic is even worse because the momentum advection kernels are not initialized

Other solutions:

• initialize a data everywhere on flow domain with 0s and return average interpolation on INITIAL

• [x] Add tests

• [x] Add an option in the action to get it right by default maybe

[moosebuild]

Job Documentation on 003519c wanted to post the following:

View the site here

This comment will be updated on new commits.

[GiudGiud]

Yes I tried re-ordering the user objects. It did not go well :S

[GiudGiud]

ok see my two last commits for the dumb stuff I have had to do to make this work.

If the cost to the framework is too high, I m happy to disallow VFR pps on INITIAL for finite volume with Rhie Chow interpolation. There is no way around the dependency resolution issues without the general dependency resolution framework, since both functions and user objects (several kinds) come into play. I have now gained significant motivation to work on that. Maybe once I m done with my other tasks for the FY I could go full time on it

[GiudGiud]

the hack with the parsed function would be also necessary for these functions since they rely on an initialSetup after their constructor to be ready for use

SolutionFunction.C:SolutionFunction::initialSetup()
ImageFunction.C:ImageFunction::initialSetup()
Axisymmetric2D3DSolutionFunction.C:Axisymmetric2D3DSolutionFunction::initialSetup()
PiecewiseLinearBase.C:PiecewiseLinearBaseTempl<BaseClass>::initialSetup()
MooseParsedVectorFunction.C:MooseParsedVectorFunction::initialSetup()
PiecewiseConstantFromCSV.C:PiecewiseConstantFromCSV::initialSetup()
MooseParsedGradFunction.C:MooseParsedGradFunction::initialSetup()

[GiudGiud]

I ll squash those commits when addressing the reviews

[moosebuild]

Job Coverage on 003519c wanted to post the following:

Framework coverage

	43cb5b	#22245 003519
	Total	Total	+/-	New
Rate	84.31%	84.29%	-0.01%	0.00%
Hits	80174	80174	-	0
Misses	14925	14939	+14	14

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

	43cb5b	#22245 003519
	Total	Total	+/-	New
Rate	85.50%	85.51%	+0.01%	100.00%
Hits	9766	9770	+4	16
Misses	1656	1656	-	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_conduction
• level_set
• misc
• navier_stokes
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• solid_properties
• stochastic_tools
• tensor_mechanics
• thermal_hydraulics
• xfem

Warnings

• framework new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

[lindsayad]

I am fine with the change to how PINSFV is setup BTW

[moosebuild]

Job Precheck on eea7875 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/22245/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 43cb5b773f57176eda58683ccd3d00513b05f1de

[GiudGiud]

Thanks for the review! And thanks to @muelcm for bringing it to our attention