Guillaume Giudicelli

Results 719 comments of Guillaume Giudicelli

It'd be better to run longer cases, like 1 min per run also use the perf graph to single out what has changed

There should be a way to get PETSc to give stats about the matrix for a large case too

I ll take a look looks like there's some easy cleanups to do

Well the coverage isnt relevant here to check that we did not loose an order of convergence. I'll try to match these tests to other ones to see if we...

yeah looks like the mms tests that were removed are for framework FV and NavierStokes cns

Hello You ll need to remove these merge commits. You usually should just rebase instead of merge. For right now I d cherry pick your actual commits to moose/devel and...

It's a good point. I think it's a good idea. We have more and more AD users, and these errors are quite sneaky. Earlier today, we got the same with...

It has not been reviewed so not yet. Any takers? EDIT: @loganharbour assigned himself so he's slated to take care of this