moose Rename NSFVFrictionFlowDiodeMaterial

Reason

The name of NSFVFrictionFlowDiodeMaterial is suggesting that the object is a directional flow resistance, but it is really a controllable resistance.

Design

Rename object.

Impact

Changes in test input files

Aug 19 '22 17:08 snschune

@lindsayad @GiudGiud do I need to deprecate the old object and add a new one? Should the deprecated object fail or warn? I would rename NSFVFrictionFlowDiodeMaterial to NSFVControllableFrictionMaterial.

Sep 19 '22 03:09 snschune

registerobjectRename will do everything you want. Are you working on a better design?

Sep 19 '22 04:09 GiudGiud

I'm just looking to rename it at this point. How do you think should this be redesigned?

Sep 19 '22 18:09 snschune

Not sure it needs to be re-designed. Do you have an input where it fails which you can share with me?

Sep 19 '22 19:09 GiudGiud

No I don't. The only objective of this is renaming. The name suggests that this object does something it doesn't do.

Sep 19 '22 19:09 snschune

it does do a directional friction flow diode if you use the control system to turn it on and off. The diode is not self-contained in this material, that's true, but it's still part of it. It needs better documentation, and probably an example. I dont object to a rename, and for a rename you only need to:

use macro I mentioned
rename it in the input file
probably patch the FHR input of the NEAMS repo

Sep 19 '22 19:09 GiudGiud