Giedrius Statkevičius

Results 227 comments of Giedrius Statkevičius
trafficstars

Unfortunately but Grafana doesn't fully verify the model before accepting the input so such weird things could happen. I'm not sure when I will have time to get around this...

@itsmylife tried fixing the tests but they are now failing with: ``` TypeError: Cannot read property 'fetch' of undefined ``` Seems like mocking doesn't work properly with `jest` for some...

@itsmylife thanks for your help, I finally managed to fix tests. Please take a look again when you have some time

Added repro on Thanos side https://github.com/thanos-io/thanos/pull/5602 + a temporary fork to show that the tests fail without this change. While working on tests, I noticed that subqueries were not handled...

Fixed according to suggestions @codesome :hugs:

Fixed in https://github.com/thanos-io/thanos/pull/5749. Thx @Rahulkumar2002 :muscle:

Let's remove this field before 1.0 IMO https://github.com/thanos-io/thanos/pull/5709

Perhaps the new `matchers` functionality (code) from Alertmanager could be used here?

Running `--compact.concurrency=3 --deduplication.func=penalty --compact.enable-vertical-compaction --deduplication.replica-label=prometheus_node_id` here with `0.22.0` and ran `sum(up)`, it completed successfully. Cannot reproduce personally. If the block is small, perhaps you could upload it somewhere? Or maybe...