Giedrius Statkevičius

Results 218 comments of Giedrius Statkevičius
trafficstars

:+1: sounds like a good feature to me. We could have `--backup.storage-config-file=...` option or something like that. If halting errors occurs and that option is not empty -> we could...

Hey! `Operation not supported` is quite different from `Permission denied` & `no such file or directory`. But how could you get such an error if the user/group under which Thanos...

Perhaps you know a reliable way to reproduce this @mv-yurchenko ?

I think it needs to be: ```yaml type: S3 config: ... ``` Notice how there are no spaces before "config:". Let us know if that helps.

Do you have persistent storage on your Thanos Store pods (I assume k8s here)? The RAM usage probably comes from building binary index headers. Maybe there is some opportunity here...

In such a situation, what happens if you curl `/api/v1/status/config` on Prometheus when it goes down?

Sounds good however I think it's worth keeping a few things in mind: * Ideally the cache wouldn't use mmap due to the reasons outlined [here](https://valyala.medium.com/mmap-in-go-considered-harmful-d92a25cb161d). This means that we...

Now that I think about this more, I would love to see this implemented as sparse files https://en.m.wikipedia.org/wiki/Sparse_file instead of shoehorning everything into k/v storage systems because they aren't as...

Ran this test quite a few times locally and cannot reproduce :/

What about `${HTTP_IP}:${HTTP_PORT}/debug/pprof/goroutine?debug=1` of Rule when this happens? Could you please upload it? I'm still not sure what happened here.