Giedrius Statkevičius

Results 218 comments of Giedrius Statkevičius
trafficstars

Was able to reproduce this by myself after updating. Reverting https://github.com/thanos-io/thanos/pull/5410 doesn't help, must be something more serious. Will try to reproduce locally && fix it. Must be some kind...

Could you please try out `main-2022-08-10-d00a713a` or later and see if it helps?

Can't reproduce this anymore with https://github.com/thanos-io/thanos/commit/d00a713a9bd66e650418bde6bd80ac7f2dc67428, will close this issue in a few days if nothing comes up.

Could you please double check if https://github.com/thanos-io/thanos/pull/5746 fixes the `nil` panic?

Will take a look soon, sorry for the delay. Could you please rebase this?

Sorry for the delay, I was on vacation. Will take a look in a bit & respond to you

Maybe my idea is stupid but in Prometheus blocks we already have: ``` "compaction": { "level": 1, "sources": [ "01FJZD9XCD6394RK2PZ3181CP5" ] }, ``` Given that Thanos Sidecar locally also "knows"...

I agree. @fpetkovski is looking into this at the moment, I believe.

Not sure about how much effort is needed for Cortex but I have done this recently for the Thanos codebase so it shouldn't take too long. Glad to hear that...