Giedrius Statkevičius

Results 234 comments of Giedrius Statkevičius
trafficstars

Looks good, I didn't think about this :+1: what do you mean by `mmap on entry?`?

Yeah, this is still needed. If no one will pick this up soon then I might try implementing something.

:+1: That would be great, we would be able to compare then. I'm working on implementing a tournament tree in Go. We could use a min-heap but it's not as...

Yeah. Planning to open a PR next week, almost done. Decided to go with a heap based solution for now since that is easier to maintain and I doubt there...

Ping :hugs: this came up again in https://cloud-native.slack.com/archives/C167KFM6C/p1670016589800069

Is there still interest in this? Could I work on it? If we are immediately performing intersection/merging after `rb.ReadFrom()`, it doesn't make sense for us to allocate gigabytes of memory...

I think Sidecar now becomes not ready in such case. Should be fixed by https://github.com/thanos-io/thanos/pull/4939

> Any news regarding this feature? This is still relevant for me. > > > Open question: Header vs Param? > > I would prefer query parameter Help wanted :hugs:

GOod point @NotAFile, let's close this. I think all requests have been implemented.

Sorry for the delay from my end. This was to be expected because `index` files became larger as a result of vertical compaction. The relevant problem is here: https://github.com/prometheus/prometheus/issues/5868. The...